-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Svelte 4 a11y warnings #1708
Comments
Since the AppRailTile has also an issue with a11y, It could be a good opportunity to refactor it and implement keyboard support. |
Just wanted to mention that I believe that one of the warnings was not silenced:
Maybe this was known? |
I would like to work on this issue 🙏. |
@Mahmoud-zino I might have you help me with one, but I really need to be hands on for anything a11y related. There's a lot of rules and we've gotta make sure changes are implemented in a very specific manner. In this case I know we'll be refactoring a number of components, but I don't know the specifics needed. Each will be determined on a case-by-case basis - even though we might end up making similar changes in multiple places. I'll try to ping you when I circle back to this though. Thanks! |
Let's review these specific changes alongside addressing the a11y concerns: |
I'm closing this as we will likely not have time to fix this in v2, and v3 will includes rewrites as we port to Svelte 5. Most, if not all, of these issues should be handled along the way. This means this issue is no longer relevant to active tasks. |
Current Behavior
These are denoted with a
TODO: Remove for V2
tag so that they may be easily searchable.Expected Behavior
No response
Steps To Reproduce
No response
Link to Reproduction / Stackblitz
No response
More Information
No response
The text was updated successfully, but these errors were encountered: