Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passive event listener Modal #1756

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add passive event listener Modal #1756

merged 1 commit into from
Jul 19, 2023

Conversation

ibilux
Copy link
Contributor

@ibilux ibilux commented Jul 17, 2023

Linked Issue

Closes #1755

Description

This error is showing when using Modals :
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 444c4a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jul 17, 2023 8:16pm

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 17, 2023

Thank you @ibilux, we'll review asap.

@AdrianGonz97 looping you in on this as I figure it may overlap with #1708

@endigo9740 endigo9740 merged commit 8efad37 into skeletonlabs:dev Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passive event listener not added to 'touchstart' and 'touchend'
2 participants