Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive event listener not added to 'touchstart' and 'touchend' #1755

Closed
ibilux opened this issue Jul 17, 2023 · 0 comments · Fixed by #1756
Closed

Passive event listener not added to 'touchstart' and 'touchend' #1755

ibilux opened this issue Jul 17, 2023 · 0 comments · Fixed by #1756

Comments

@ibilux
Copy link
Contributor

ibilux commented Jul 17, 2023

This error is showing when using Modals :
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
I think it's related to this :

on:touchstart
on:touchend

It should be:

on:touchstart|passive
on:touchend|passive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant