-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Generator UX - Wizard UI Structure #1178
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Still to do:
|
@Sarenor make sure to sync with Rhys if you haven't yet. He was already making progress on some Theme Generator improvements. |
Checked his PR, as far as I saw it was only in the "Color-Service-Layer" (unless that changed, if so that's on me and I'll handle the merge conflict, if we even deem this good enough to merge) |
@Sarenor I believe you said you wouldn't be available to work on this again until tomorrow or the next day, so let's plan to sync on this then (time wiling). Thanks! |
…me generator view
@Sarenor sorry for taking so long to circle back to this. Unfortunately testing the current version throws a 500 error. If you can get this back in a working state I can review and provide more guidance and feedback on this. That said, I've been thinking about this since the idea came up. The original goal was to segment things, to reduce the information density thrown at you at once. We proposed the wizard idea, but the more I think about it the more I think a "tabbed" interface might work better. Either full on Tabs or the AppRail might work well here. Here's a quick wireframe mock: The general idea is you would have a three column layout:
By doing this you can quickly navigate between options while seeing the preview at a glance. Anyways, just a thought. Let me know what you think. |
Probably a better way, yeah. |
… do. 14 inch laptop screen isn't quite as conducting to sweeping refactorings as expected.
Just so it's stated here - I'm leaning towards closing out this issue, but still using some of the learning and discussion from it in my new updates next week. I'll leave this be for now, but just a heads up so you don't implement more work that won't carry forward. |
Noted. Then I'll spent my weekend doing other things |
Per our discussion on Discord I'm closing this but will take the changes into consideration when we revisit theme generation soon. Thanks! |
Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
Initial and very ugly draft to refactor the Theme Generator into a Wizard Based Approach
Partially fixes #1141