Skip to content

Conversation

@ak4zh
Copy link
Contributor

@ak4zh ak4zh commented Aug 22, 2023

Linked Issue

Closes #1876

Description

  • Moved .btn class to button prop so it can be customised to render a buton without hardcoded styles.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: e8bcc6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 22, 2023 4:07pm

@ak4zh
Copy link
Contributor Author

ak4zh commented Aug 22, 2023

I adjusted the default value of width to w-full so that the buttons within button groups would display properly. However, it seems appropriate to restore the original setting and advise that when utilized with button groups, the width should be explicitly set to w-full.

@endigo9740
Copy link
Contributor

endigo9740 commented Aug 22, 2023

@ak4zh thanks for the PR. Just FYI we do not document changeset changes for /site projects, only those in /packages. So in this case no changeset reference was needed for the documentation site. Likewise make sure you prefix the change with chore: or similar. I've implemented a quick fix this for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants