-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT Tailwind Plugin Refactor #2431
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@niktek @AdrianGonz97 this PR is now ready to merge. This is a huge first step towards v3 and will help unblock everything that comes next. So I cannot under emphasize the importance of getting this in. That said, I'd welcome a review by you two, but otherwise I'd say we go ahead and merge and follow up with any other additional changes or improvements over time, in smaller PRs. Note that once this is merged, any v2 Currently we'll only have ONE functional theme, called @niktek given the CI/CD errors on this page are Vercel-related, let me know if you need anything from me to help troubleshoot. But this SHOULD be deployed to the CF instance and should be operational here: Note I'll be away for part of the afternoon, but back on later tonight or this week. Thanks guys! |
packages/skeleton/src/plugin/components/legacy/horizontal-rules.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some superficial comments to worry about. Will get this deployed soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdrianGonz97 be good to know some of the background design decisions behind going the exec route. I can see on the one hand that it offers flexibility in updating what needs to be built without having to touch this code. The error swallowing issue is now resolved. Using https://vitejs.dev/guide/api-javascript#build directly via API might give us better error handling options - but there might be other issues.
@niktek @AdrianGonz97 I've implemented the changes discussed above and on Discord. Minus of course a few things that Adrian will need to be involved in:
That said, let's plan to follow these as follow ups. I will now move forward with merging this into the |
Linked Issue
Closes #2360
Description
Refactor the theme format and Tailwind plugin.