Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT Popver - Consistent Positioner and Z-Index Classes #3029

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Dec 6, 2024

Linked Issue

Closes #3009

Description

Implements consistent Positioner and Z-Index classes to the following Svelte components:

  • Popvers
  • Tooltips
  • Comboboxes
  • Modals

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Skeleton v3 contributions must target the next branch (NEVER dev or master)
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 430820c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Dec 6, 2024 7:33pm
skeleton-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
skeleton-themes ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:33pm

@endigo9740 endigo9740 mentioned this pull request Dec 6, 2024
@endigo9740 endigo9740 merged commit f46cd41 into next Dec 6, 2024
7 of 8 checks passed
@endigo9740 endigo9740 deleted the chore/popover-z-index-props branch December 6, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant