ParseItemsToLoad: add __bool__() and use it to bring tagger to front

picard/tagger.py

@@ -195,6 +195,9 @@ def __init__(self, items):
                 # .path returns / before actual link
                 self.urls.add(parsed.path[1:])
 
+    def __bool__(self):
+        return bool(self.files or self.mbids or self.urls)
+
 
 class Tagger(QtWidgets.QApplication):
 
@@ -351,11 +354,13 @@ def load_to_picard(self, items):
 
         if parsed_items.files:
             self.add_paths(parsed_items.files)
-            self.bring_tagger_front()
+
         if parsed_items.urls or parsed_items.mbids:
             file_lookup = self.get_file_lookup()
             for item in parsed_items.mbids | parsed_items.urls:
                 thread.to_main(file_lookup.mbid_lookup, item, None, None, False)
+
+        if parsed_items:
             self.bring_tagger_front()
 
     def enable_menu_icons(self, enabled):

test/test_tagger_message_parsing.py

@@ -38,3 +38,31 @@ def test(self):
         self.assertSetEqual(result.mbids, {"recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94"}, "MBIDs test")
         self.assertSetEqual(result.urls, {"recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
             "recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94"}, "URLs test")
+
+    def test_bool_files_true(self):
+        test_cases = {
+            "test_case.mp3",
+        }
+        self.assertTrue(ParseItemsToLoad(test_cases))
+
+    def test_bool_mbids_true(self):
+        test_cases = {
+            "mbid://recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
+        }
+        self.assertTrue(ParseItemsToLoad(test_cases))
+
+    def test_bool_urls_true(self):
+        test_cases = {
+            "https://musicbrainz.org/recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
+        }
+        self.assertTrue(ParseItemsToLoad(test_cases))
+
+    def test_bool_invalid_false(self):
+        test_cases = {
+            "mbd://recording/7cd3782d-86dc-4dd1-8d9b-e37f9cbe6b94",
+        }
+        self.assertFalse(ParseItemsToLoad(test_cases))
+
+    def test_bool_empty_false(self):
+        test_cases = {}
+        self.assertFalse(ParseItemsToLoad(test_cases))