Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: make pip install invocations zsh-compatible #107

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

rodionovd
Copy link
Contributor

Running these commands as is doesn't work in zsh (the default shell in macOS) since it treats square brackets as special characters:

pip install fig2sketch[fast]
# zsh: no matches found: fig2sketch[fast]

@tmdvs
Copy link
Member

tmdvs commented Feb 29, 2024

@rodionovd You should be able to rebase main into your branches and 🤞 the GitHub actions will pass 🚥

Running these commands as is doesn't work in zsh as it treats square brackets as special characters

Signed-off-by: Dmitry Rodionov <i.am.rodionovd@gmail.com>
@rodionovd rodionovd force-pushed the fix/pip-install-in-readme branch from b12b89a to ad19d2d Compare February 29, 2024 16:15
@tmdvs tmdvs self-requested a review February 29, 2024 16:15
Copy link
Member

@tmdvs tmdvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you!

@tmdvs tmdvs merged commit 5db48bf into sketch-hq:main Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants