Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Resolve pyinstaller release errors #112

Merged
merged 1 commit into from
Mar 1, 2024
+19 −20
Merged

💥 Resolve pyinstaller release errors #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ jobs:
- os: linux
arch: x86_64
runs: ubuntu-latest
ext: ''
ext: ""
- os: windows
arch: x86_64
runs: windows-latest
ext: '.exe'
ext: ".exe"
- os: macos
arch: x86_64
runs: macos-12
ext: ''
ext: ""
- os: macos
arch: arm64
runs: macos-14
ext: ''
ext: ""

runs-on: ${{ matrix.runs }}
steps:
Expand All @@ -34,17 +34,17 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.11'
python-version: "3.11"
architecture: x64 # Otherwise the runner will try to download Python arm64, which is not available. x64 has support for both archs (universal2).
- name: Install latest stable
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
toolchain: stable
override: true
- name: Build
run: |
python -m pip install --upgrade pip
pip install pyinstaller
pip install "pyinstaller>=5.12"
Copy link
Member Author

@tmdvs tmdvs Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the specific "fix" - everything else is linting :feelsgood:

pip install certifi
pip install maturin
pip install .[fast]
Expand All @@ -56,18 +56,18 @@ jobs:
- name: zip release
uses: thedoctor0/zip-release@main
with:
type: 'zip'
filename: 'fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip'
directory: 'dist'
path: '*'
type: "zip"
filename: "fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip"
directory: "dist"
path: "*"
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: builds
path: dist/fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip

build-macos-universal:
needs: [ build ]
needs: [build]
runs-on: macos-latest
steps:
- name: Download artifact
Expand Down Expand Up @@ -97,19 +97,18 @@ jobs:
- name: zip release
uses: thedoctor0/zip-release@main
with:
type: 'zip'
filename: 'fig2sketch-macos-universal.zip'
directory: 'dist'
path: '*'
type: "zip"
filename: "fig2sketch-macos-universal.zip"
directory: "dist"
path: "*"
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: builds
path: dist/fig2sketch-macos-universal.zip


create-release:
needs: [ build, build-macos-universal ]
needs: [build, build-macos-universal]
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -132,7 +131,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: '3.11'
python-version: "3.11"
- name: Install build tools
run: pip install build
- name: Build source distribution
Expand Down
Loading