Fix issues with font downloading and zombie refs #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdvs
force-pushed
the
fix/improved-font-errors-and-zombie-refs
branch
3 times, most recently
from
7360c6b to
d3f380d
Compare
tmdvs
force-pushed
the
fix/improved-font-errors-and-zombie-refs
branch
2 times, most recently
from
72f5c4f to
a40bed0
Compare
tmdvs
force-pushed
the
fix/improved-font-errors-and-zombie-refs
branch
4 times, most recently
from
9380f8c to
7f5fc2d
Compare
tmdvs
force-pushed
the
fix/improved-font-errors-and-zombie-refs
branch
from
7f5fc2d to
5301780
Compare
arseniocosta1
approved these changes
May 15, 2024
Comment on lines
+66
to
+70
| except Exception as e: | ||
| if isinstance(e, font.FontNotFoundError) or ( | ||
| isinstance(e, HTTPError) and e.code == 404 | ||
| ): | ||
| logging.warning(f"Could not find font {font_descriptor} via Google Fonts") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where by Google Fonts have changed the URL to font downloads. This prevents fonts from being correctly embedded in Sketch documents.
At the same time we have an issue with zombie references. This fix attempts to patch both and unblock future work.
PS I've also bumped some deps for stabilities sake
Fixes: #119