Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👀 Fallback to sensible defaults when reading some fig node properties #123

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

tmdvs
Copy link
Member

@tmdvs tmdvs commented Jun 12, 2024

We've recently had instances of some frame and text layer properties not being written to the .fig model data. In these cases, we will fall back on the default values.

I have tackled the most common/those we've encountered but haven't provided defaults for everything at this time.

@tmdvs tmdvs added the bug Something isn't working label Jun 12, 2024
SheffieldKevin
SheffieldKevin previously approved these changes Jun 12, 2024
@tmdvs tmdvs changed the title 👀 Fallback to sensible defaults when reading some node properties 👀 Fallback to sensible defaults when reading some fig node properties Jun 12, 2024
@tmdvs tmdvs force-pushed the fix/sensible-defaults-for-node-properties branch from 811a39d to 9471aee Compare June 12, 2024 11:16
@tmdvs tmdvs merged commit f47fdd9 into main Jun 12, 2024
4 checks passed
@tmdvs tmdvs deleted the fix/sensible-defaults-for-node-properties branch June 12, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants