feat(util): #isUrl accepts file protocol

skick1234 · Jul 20, 2023 · e90004d · e90004d
1 parent 613364a
commit e90004d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/util.ts b/src/util.ts
@@ -57,16 +57,17 @@ export function parseNumber(input: any): number {
   if (typeof input === "string") return Number(input.replace(/[^\d.]+/g, "")) || 0;
   return Number(input) || 0;
 }
+const SUPPORTED_PROTOCOL = ["https:", "http:", "file:"] as const;
 /**
  * Check if the string is an URL
  * @param {string} input input
  * @returns {boolean}
  */
-export function isURL(input: any): input is `http://${string}` | `https://${string}` {
+export function isURL(input: any): input is `${(typeof SUPPORTED_PROTOCOL)[number]}//${string}` {
   if (typeof input !== "string" || input.includes(" ")) return false;
   try {
     const url = new URL(input);
-    if (!["https:", "http:"].includes(url.protocol) || !url.host) return false;
+    if (!SUPPORTED_PROTOCOL.some(p => p === url.protocol)) return false;
   } catch {
     return false;
   }

diff --git a/tests/util.test.ts b/tests/util.test.ts
@@ -135,7 +135,7 @@ test("isURL()", () => {
   expect(isURL("")).toBe(false);
   expect(isURL("not an url")).toBe(false);
   expect(isURL("https://")).toBe(false);
-  expect(isURL("file://abc")).toBe(false);
+  expect(isURL("file://abc")).toBe(true);
   expect(isURL("http://localhost:1234")).toBe(true);
   expect(isURL("https://distube.js.org/")).toBe(true);
   expect(isURL("http://distube.js.org:433")).toBe(true);