deps: upgrade uuid to v9.0.0 for jest+esm issue
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is described well here: microsoft/accessibility-insights-web#5421 (comment) They originally fixed the issue with a custom resolver (microsoft/accessibility-insights-web@9ad4e61#diff-10ce3d2c4d812be4f9bbaceb999b48c91538e4ccfc23dc585c59deb316d0d689), but then replaced that workaround with an upgrade to uuid v9.0.0 when it became available (microsoft/accessibility-insights-web@6d1c3a3). uuid v9.0.0 https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#900-2022-09-05
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbranchaud
commented
Jun 21, 2023
Comment on lines
17
to
19
| "jest": { | ||
| "preset": "@skillrecordings/scripts/jest/node", | ||
| "testEnvironment": "node" | ||
| "preset": "@skillrecordings/scripts/jest/node" | ||
| }, |
There was a problem hiding this comment.
Getting all of the uuid dependencies on v9 and then allowing commerce-server jest to use the default testEnvironment fixes the ESM/Jest/UUID issue.
joelhooks
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is described well here: microsoft/accessibility-insights-web#5421 (comment)
They originally fixed the issue with a custom resolver
(microsoft/accessibility-insights-web@9ad4e61#diff-10ce3d2c4d812be4f9bbaceb999b48c91538e4ccfc23dc585c59deb316d0d689),
but then replaced that workaround with an upgrade to uuid v9.0.0 when it
became available
(microsoft/accessibility-insights-web@6d1c3a3).
uuid v9.0.0 https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#900-2022-09-05