-
Notifications
You must be signed in to change notification settings - Fork 287
feat: restructure workflows to use latest conventions, remove step 4b, simplify step1 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A restructuring of exercise workflows to adopt the latest conventions, remove an unused step 4b, and streamline the initial setup.
- Upgraded all
skills/exercise-toolkit
workflow references fromv0.6.0
tov0.7.0
, replaced manualgh issue comment
steps withGrantBirki/comment@v2.1.1
, and switched fromISSUE_URL
toISSUE_REPOSITORY
/ISSUE_NUMBER
. - Deleted the deprecated
4b-copilot-on-github.yml
workflow and simplified the enable/disable logic for step 1. - Enhanced instructional markdown by fixing Handlebars syntax, adding Copilot Ask Mode guidance, and updating exercise links.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.github/workflows/4b-copilot-on-github.yml | Removed unused step-4b workflow. |
.github/workflows/4-copilot-on-github.yml | Bumped to v0.7.0, refactored comment posting to GrantBirki/comment. |
.github/workflows/3b-copilot-agent-mode.yml | Renamed and streamlined keyword checks, updated comment action usage. |
.github/workflows/3-copilot-edits.yml | Upgraded version, unified comment edits via GrantBirki/comment. |
.github/workflows/2-first-introduction.yml | Updated toolkit version, refactored comment updates, and env vars. |
.github/workflows/1-preparing.yml | Bumped version, replaced manual comments, and simplified next-step. |
.github/workflows/0-start-exercise.yml | Switched to v0.7.0, replaced comment actions, and adjusted env setup. |
.github/steps/1-preparing.md | Corrected variable syntax and clarified Copilot Ask Mode instruction. |
.github/steps/x-review.md | Updated external link to use learn.github.com . |
Comments suppressed due to low confidence (3)
.github/workflows/4-copilot-on-github.yml:54
- The
REVIEW_FILE
environment variable is referenced but never defined in this job. Please define it (e.g.,env: REVIEW_FILE: …
) or use the correct variable name.
file: ${{ env.REVIEW_FILE }}
.github/workflows/3b-copilot-agent-mode.yml:54
- This step references
${{ env.ISSUE_REPOSITORY }}
and${{ env.ISSUE_NUMBER }}
but those environment variables aren’t set for this job. Add them underenv:
so the comment action can target the correct issue.
uses: GrantBirki/comment@v2.1.1
.github/workflows/3-copilot-edits.yml:71
- The
id
for the styles.css check is set tocheck-app-js
, duplicating the prior step and not matching the latersteps.check-styles-css
reference. Rename this tocheck-styles-css
for clarity and to align with the results-table keys.
id: check-app-js
Summary
This pull request includes updates to improve workflows, enhance instructions, and streamline the use of GitHub Copilot in the exercise toolkit. The most significant changes involve upgrading workflow dependencies, improving issue handling, and refining instructional content.
Workflow Updates:
.github/workflows/0-start-exercise.yml
,.github/workflows/1-preparing.yml
,.github/workflows/2-first-introduction.yml
,.github/workflows/3-copilot-edits.yml
: Updated references fromv0.6.0
tov0.7.0
forskills/exercise-toolkit
workflows, ensuring compatibility with the latest version. [1] [2] [3] [4].github/workflows/0-start-exercise.yml
,.github/workflows/1-preparing.yml
,.github/workflows/2-first-introduction.yml
,.github/workflows/3-copilot-edits.yml
: Replaced manual GitHub issue comment handling withGrantBirki/comment@v2.1.1
for improved automation and maintainability. [1] [2] [3] [4]Instructional Content Enhancements:
.github/steps/1-preparing.md
: Clarified instructions to use Copilot Ask Mode for prompts and updated the example prompt to directly include the branch name "accelerate-with-copilot" for better user guidance. [1] [2].github/steps/x-review.md
: Updated the link to GitHub Skills exercises to use the newlearn.github.com
domain for consistency and accuracy.Issue Handling Improvements:
.github/workflows/0-start-exercise.yml
,.github/workflows/1-preparing.yml
,.github/workflows/2-first-introduction.yml
,.github/workflows/3-copilot-edits.yml
: Transitioned from usingISSUE_URL
toISSUE_NUMBER
andISSUE_REPOSITORY
for more precise issue tracking and handling. [1] [2] [3] [4]These changes collectively enhance the usability, maintainability, and clarity of the exercise toolkit workflows and instructions.
Changes
Closes:
Task list