chore: add maga to coingecko #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
requested review from
davidterpay,
aljo242,
Eric-Warehime and
technicallyty
as code owners
nivasan1
added
preview
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
=======================================
Coverage ? 56.60%
=======================================
Files ? 244
Lines ? 12288
Branches ? 0
=======================================
Hits ? 6956
Misses ? 4644
Partials ? 688 ☔ View full report in Codecov by Sentry. |
nivasan1
added
the
raydium_markets
|
Unclear why this is urgent or needed right now (wouldn't this just be a config change on the chain side/marketmap side?), need more explanation. |
|
Reopening |
aljo242
approved these changes
Jun 24, 2024
davidterpay
reviewed
Jun 24, 2024
cmd/constants/markets.go
Outdated
Comment on lines
6233
to
6242
| { | ||
| "name": "coingecko_api", | ||
| "off_chain_ticker": "ponke/usd" | ||
| } | ||
| ] | ||
| }, | ||
| "USA/USD": { | ||
| "ticker": { | ||
| "currency_pair": { | ||
| "Base": "USA", |
There was a problem hiding this comment.
can you pipe this into a json formatter
davidterpay
approved these changes
Jun 24, 2024
|
kek |
nivasan1
force-pushed
the
nv/add-trump-cg-market
branch
from
9c4f787 to
c053a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
maga/usdcoingecko feed to the coingecko marketsmake start-all-devand the price is inline w/ the analogous CG feed