-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WrappedPreBlocker #567
feat: WrappedPreBlocker #567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 56.57% 56.38% -0.20%
==========================================
Files 246 246
Lines 12506 12550 +44
==========================================
+ Hits 7075 7076 +1
- Misses 4731 4773 +42
- Partials 700 701 +1 ☔ View full report in Codecov by Sentry. |
…hub.com:skip-mev/slinky into tyler/blo-1459-simapp-doesnt-work-with-xupgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just switched all the tests over to the non-deprecated version of the method, and added a case to ensure PreBlock
from ModuleManager
is actually called. lmk if this is ideal or not!
previously, simapp would not work with x/upgrade handlers. this is because upgrades rely on
PreBlocker
but this was being overwritten with the oracle PreBlocker.fixed by creating a new method on oracle's PreBlockHandler: "WrappedPreBlocker" which takes a
module.Manager
, and call the PreBlock function to trigger upgrades. h/t @aljo242 for showing me the wayi added a comment to the existing PreBlocker that notes it is deprecated and to use WrappedPreBlocker instead.