Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [BLO-1444] Bitstamp API Provider #571

Merged
merged 14 commits into from
Jul 10, 2024
Merged

feat: [BLO-1444] Bitstamp API Provider #571

merged 14 commits into from
Jul 10, 2024

Conversation

davidterpay
Copy link
Contributor

@davidterpay davidterpay commented Jul 2, 2024 •
edited
Loading

BLO-1444

@davidterpay davidterpay marked this pull request as ready for review July 2, 2024 18:11
@davidterpay davidterpay added preview Select this label when you want to preview a test chain + sidecar deployment in K8S vpn Select this label when you want to proxy all traffic in the deployment through a VPN. marketmap_provider=dydx_research Select this label if you want to deploy a sidecar that reads markets from dYdX mainnet + research. labels Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (f3f5a19) to head (82a89a4).
Report is 1 commits behind head on main.

Files Patch % Lines
providers/apis/bitstamp/api_handler.go 71.73% 8 Missing and 5 partials ⚠️
providers/factories/oracle/api.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   56.52%   56.58%   +0.06%     
==========================================
  Files         247      248       +1     
  Lines       12653    12697      +44     
==========================================
+ Hits         7152     7185      +33     
- Misses       4795     4801       +6     
- Partials      706      711       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay changed the title feat: Bitstamp API Provider feat: [BLO-1444] Bitstamp API Provider Jul 2, 2024
Alex Johnson and others added 12 commits July 3, 2024 13:57
Merge branch 'main' into terpay/bitstamp-api-impl
d9344c7
Merge branch 'main' into terpay/bitstamp-api-impl
517f840
@nivasan1
Merge branch 'main' into terpay/bitstamp-api-impl
3670a9e
tidy
7bcce8d
fix
b513ab5
Merge branch 'main' into terpay/bitstamp-api-impl
6f597ee
@nivasan1 @daviddzhou @davidterpay
docs: rename slinky to connect in our docs [BLO-1456] (#579)
48908fc 
Co-authored-by: Alex Johnson <alex@skip.money>
Co-authored-by: David Zhou <29874473+daviddzhou@users.noreply.github.com>
@Zygimantass @davidterpay
chore(ci): run codespell on the actual PR commit, instead of the merg…
b0a74d5 
…e one (#583)
@dependabot @davidterpay
chore(deps): bump the go_modules group with 2 updates (#585)
6e22ca4 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @davidterpay
chore(deps): bump the go_modules group across 2 directories with 2 up…
2b78b62 
…dates (#586)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Johnson <alex@skip.money>
@davidterpay
Merge branch 'main' into terpay/bitstamp-api-impl
dd4f33d
@davidterpay
update interval
82a89a4
@davidterpay davidterpay merged commit 17fa5e6 into main Jul 10, 2024
16 checks passed
@davidterpay davidterpay deleted the terpay/bitstamp-api-impl branch July 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@nivasan1 nivasan1 Awaiting requested review from nivasan1

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime

@technicallyty technicallyty Awaiting requested review from technicallyty

Assignees
No one assigned
Labels
marketmap_provider=dydx_research Select this label if you want to deploy a sidecar that reads markets from dYdX mainnet + research. preview Select this label when you want to preview a test chain + sidecar deployment in K8S vpn Select this label when you want to proxy all traffic in the deployment through a VPN.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidterpay @aljo242 @nivasan1 @Zygimantass