feat: Version RPC #613
Merged
feat: Version RPC #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
requested review from
nivasan1,
aljo242,
Eric-Warehime and
technicallyty
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 56.51% 56.45% -0.06%
==========================================
Files 249 249
Lines 12971 12989 +18
==========================================
+ Hits 7330 7333 +3
- Misses 4933 4948 +15
Partials 708 708 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Jul 19, 2024
proto/slinky/service/v1/oracle.proto
Outdated
|
|
||
| // QueryVersionResponse defines the response type for the Version method. | ||
| message QueryVersionResponse { | ||
| // version defines the current version of the oracle service. |
There was a problem hiding this comment.
Suggested change
| // version defines the current version of the oracle service. | |
| // Version defines the current version of the oracle service. |
Comments on the proto should start capitalized like they will be in Go so that they can be proper godoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.