feat: Refresh prices on heartbeats #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
preview
davidterpay
requested review from
nivasan1,
aljo242,
Eric-Warehime and
technicallyty
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 56.51% 56.47% -0.05%
==========================================
Files 250 250
Lines 13023 13045 +22
==========================================
+ Hits 7360 7367 +7
- Misses 4955 4970 +15
Partials 708 708 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Jul 24, 2024
Comment on lines
+69
to
+71
| cache[strings.ToLower(ticker.GetOffChainTicker())] = ticker | ||
| cache[ticker.GetOffChainTicker()] = ticker | ||
| cache[strings.ToUpper(ticker.GetOffChainTicker())] = ticker |
There was a problem hiding this comment.
why do we need 3 entries in the cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.