feat: install script #626
Merged
feat: install script #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
requested review from
davidterpay,
nivasan1,
aljo242 and
Eric-Warehime
as code owners
|
Please help me test this!!! run this: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 56.49% 56.48% -0.02%
==========================================
Files 250 250
Lines 13068 13068
==========================================
- Hits 7383 7381 -2
- Misses 4977 4979 +2
Partials 708 708 ☔ View full report in Codecov by Sentry. |
|
works for me! do we want to call it |
aljo242
approved these changes
Jul 25, 2024
aljo242
reviewed
Jul 25, 2024
| rm -rf "${TEMP_DIR}" | ||
| rm "${FILE_NAME}" | ||
|
|
||
| echo "Slinky ${VERSION} has been installed successfully!" |
There was a problem hiding this comment.
could have another output that is just like run slinky --help for more info
but not big deal really
codecov.yml
Outdated
Comment on lines
2
to
3
| - "**/*.*" | ||
| - "!**/*.go" |
There was a problem hiding this comment.
We should probably add some additional exclusions like pulsar, pb, etc.
technicallyty
deleted the
tyler/blo-1525-curl-command-for-installing-connect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Sourceoption to checkout latest tag instead of using main