-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor utils into pure functions #634
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 56.59% 56.59% -0.01%
==========================================
Files 254 254
Lines 13416 13420 +4
==========================================
+ Hits 7593 7595 +2
- Misses 5094 5096 +2
Partials 729 729 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like we only log on error messages, so alternatively you could just:
- return a more descriptive error (what the logger is spitting out currently)
- and change our internal callers of those functions to log the error
oh nvm thats not true of all of them sadge.. maybe we could kill that log so the function sig is pretty 👉🏻👈🏻 |
Move these util functions out of the API handler so that they can be used as library functions in dydx.
Had to move the loggers into the args, and made it so they can be supplied as
nil
if you don't want to hook the zap logger up.