-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove modules #711
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (3)slashingkeeper These words are not needed and should be removedalr anypb anys arounds badprice beginblocker bitsets cdb cmthash commitheight Concluson coretypes cvp ddd Devation dfa endblocker goautoneg GOM goodprice IDbz incentivize initgenesis Macbook msc munnerz oraclevetypes outpkg pbk pkany pkb pkv Prce pubkeys pvks sdktypes statelessly submitters tmhash UIDs underperform unescrow unmashalling VEbz vih voteaggregator wrtTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:skip-mev/connect.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/skip-mev/connect/actions/runs/10601499930/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (797) from .github/actions/spelling/expect.txt and unrecognized words (3)
Consider adding them (in cspell:python/src/python/python-lib.txt
cspell:fullstack/dict/fullstack.txt
cspell:java/src/java.txt
cspell:filetypes/filetypes.txt
cspell:java/src/java-terms.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See If the flagged items are 🤯 false positivesIf items relate to a ...
🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 56.42% 56.04% -0.39%
==========================================
Files 258 206 -52
Lines 13551 11472 -2079
==========================================
- Hits 7646 6429 -1217
+ Misses 5166 4444 -722
+ Partials 739 599 -140 ☔ View full report in Codecov by Sentry. |
legendary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with haste
Remove x/sla x/incentives x/alerts. If we need them we will bring them back.