Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove modules #711

Merged
merged 6 commits into from
Aug 28, 2024
Merged

chore: Remove modules #711

merged 6 commits into from
Aug 28, 2024

Conversation

Eric-Warehime
Copy link
Collaborator

Remove x/sla x/incentives x/alerts. If we need them we will bring them back.

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

slashingkeeper
slashingmodulev
slashingtypes

These words are not needed and should be removed alr anypb anys arounds badprice beginblocker bitsets cdb cmthash commitheight Concluson coretypes cvp ddd Devation dfa endblocker goautoneg GOM goodprice IDbz incentivize initgenesis Macbook msc munnerz oraclevetypes outpkg pbk pkany pkb pkv Prce pubkeys pvks sdktypes statelessly submitters tmhash UIDs underperform unescrow unmashalling VEbz vih voteaggregator wrt

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:skip-mev/connect.git repository
on the eric/remove-modules branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/skip-mev/connect/actions/runs/10601499930/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (797) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary Entries Covers Uniquely
cspell:python/src/python/python-lib.txt 2417 8 4
cspell:fullstack/dict/fullstack.txt 419 5 4
cspell:java/src/java.txt 2464 5 3
cspell:filetypes/filetypes.txt 264 4 3
cspell:java/src/java-terms.txt 920 4 1

Consider adding them (in .github/workflows/spell.yml) in jobs:/build: to extra_dictionaries:

          cspell:python/src/python/python-lib.txt
          cspell:fullstack/dict/fullstack.txt
          cspell:java/src/java.txt
          cspell:filetypes/filetypes.txt
          cspell:java/src/java-terms.txt

To stop checking additional dictionaries, add (in .github/workflows/spell.yml):

check_extra_dictionaries: ''
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings Count
⚠️ no-newline-at-eof 3

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling,
please merge to your PR's base branch to get the version configured for your repository.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.04%. Comparing base (5ca2f00) to head (0167c7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   56.42%   56.04%   -0.39%     
==========================================
  Files         258      206      -52     
  Lines       13551    11472    -2079     
==========================================
- Hits         7646     6429    -1217     
+ Misses       5166     4444     -722     
+ Partials      739      599     -140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aljo242
Copy link
Contributor

aljo242 commented Aug 28, 2024

legendary

Copy link
Contributor

@wesl-ee wesl-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with haste

@Eric-Warehime Eric-Warehime merged commit 57f6661 into main Aug 28, 2024
16 of 17 checks passed
@Eric-Warehime Eric-Warehime deleted the eric/remove-modules branch August 28, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants