-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validation service #724
Conversation
This comment has been minimized.
This comment has been minimized.
|
||
import "net" | ||
|
||
func IsValidAddress(address string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to a common folder so it could be used by other code
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)libhttp To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:skip-mev/connect.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/skip-mev/connect/actions/runs/10706806834/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (755) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them (in cspell:python/src/python/python-lib.txt
cspell:fullstack/dict/fullstack.txt
cspell:java/src/java.txt
cspell:filetypes/filetypes.txt
cspell:java/src/java-terms.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See If the flagged items are 🤯 false positivesIf items relate to a ...
🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 55.97% 55.52% -0.45%
==========================================
Files 206 208 +2
Lines 11475 11582 +107
==========================================
+ Hits 6423 6431 +8
- Misses 4452 4552 +100
+ Partials 600 599 -1 ☔ View full report in Codecov by Sentry. |
@@ -6354,67 +6259,6 @@ var ( | |||
} | |||
] | |||
}, | |||
"RNDR/USD": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the dead feeds. Validation fails when they are here and passing when they are gone
cmd/connect/main.go
Outdated
int(validation.DefaultValidationPeriod), | ||
"Duration to run in validation mode. Note: this flag is only used if mode == \"validate\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me what the units are for this int--hours minutes days etc.
@@ -44,6 +44,7 @@ services: | |||
"--market-config-path", "/data/markets.json", | |||
"--pprof-port", "6060", | |||
"--run-pprof", | |||
"-m", "validate" # uncomment to run in validation mode with default config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be commented out? comment suggests so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a test for this logic?
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Spins up and internal validation service that can introspect the live prices the sidecar is producing.
If any of the prices is below our configured liveness threshold (99%, perhaps this should be stricter), the process will terminate itself.
If all prices are valid after a configured amount of time, the process will gracefully tear down and end sucessfully.