chore: update ICS #759
Merged
chore: update ICS #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 10:31
aljo242
requested review from
Eric-Warehime,
technicallyty,
wesl-ee and
zrbecker
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 57.00% 57.03% +0.02%
==========================================
Files 208 208
Lines 11630 11632 +2
==========================================
+ Hits 6630 6634 +4
+ Misses 4396 4395 -1
+ Partials 604 603 -1 ☔ View full report in Codecov by Sentry. |
tests/integration/go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/skip-mev/connect/tests/integration/v2 | |||
| module github.com/skip-mev/connect/v2/tests/integration | |||
There was a problem hiding this comment.
they way it was previously made more sense to me. any reason to change this here?
There was a problem hiding this comment.
this way seems to not work. When adding new module to neutron:
go: finding module for package github.com/skip-mev/connect/tests/integration/v2
go: found github.com/skip-mev/connect/tests/integration/v2 in github.com/skip-mev/connect/tests/integration/v2 v2.0.0
go: neutron/tests/connect tested by
neutron/tests/connect.test imports
github.com/skip-mev/connect/tests/integration/v2: github.com/skip-mev/connect/tests/integration/v2@v2.0.0: parsing go.mod:
module declares its path as: github.com/skip-mev/connect/v2/tests/integration/v2
but was required as: github.com/skip-mev/connect/tests/integration/v2
technicallyty
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CON-1753
updates
interchain-securityto v6