feat: e2e integration #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
commented
Feb 7, 2024
| } | ||
| // if err := umpt.pricesKeeper.PerformStatefulPriceUpdateValidation(umpt.ctx, umpt.msg, true); err != nil { | ||
| // return err | ||
| // } | ||
|
|
There was a problem hiding this comment.
This is temporary (just to make things work), we can remove this once we are aggregating prices that are proposed via GetValidMarketPriceUpdates instead of directly from sidecar
nivasan1
commented
Feb 7, 2024
protocol/go.sum
Outdated
| github.com/skip-mev/slinky v0.2.1-0.20240205201114-084e56f076aa h1:19BBqLYZ5d83vVOHHJHY1pD3fbJbdJn6SprzYlk/BS4= | ||
| github.com/skip-mev/slinky v0.2.1-0.20240205201114-084e56f076aa/go.mod h1:/ze8FaykAaF0wnxU9xtgzmoAYlTA1ibftejaG8mBzms= | ||
| github.com/skip-mev/slinky v0.2.1-0.20240207182816-93fd020dc214 h1:rqBnz5/29D0GYwpAlcSowOWn5RwH7u7HzZtyTcN3hnY= | ||
| github.com/skip-mev/slinky v0.2.1-0.20240207182816-93fd020dc214/go.mod h1:C3jPCOaezvch/1iIfSyRp4j4pF+22T33KPzdSY1V/0Q= |
There was a problem hiding this comment.
This PR in slinky: skip-mev/connect#90
nivasan1
commented
Feb 7, 2024
| @@ -182,15 +182,16 @@ func (k Keeper) performDeterministicStatefulValidation( | |||
|
|
|||
| // Check price respects min price change. | |||
| if !isAboveRequiredMinPriceChange(marketParamPrice, priceUpdate.Price) { | |||
| return errorsmod.Wrapf( | |||
| // ignore the error + log | |||
| ctx.Logger().Error(errorsmod.Wrapf( | |||
There was a problem hiding this comment.
Also can remove once we propose prices via GetValidMarketPriceUpdates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
make localnet-start), and subsequently (make localnet-compose-up)