Remove implicit ISODateTimeField #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formulka
commented
Feb 16, 2023
| @@ -1055,8 +1055,6 @@ def _get_name(self): | |||
| return force_text(remove_accent(force_text(self.model._meta.verbose_name_plural))) | |||
|
|
|||
| def formfield_for_dbfield(self, db_field, **kwargs): | |||
| if isinstance(db_field, DateTimeField): | |||
| kwargs.update({'form_class': ISODateTimeField}) | |||
There was a problem hiding this comment.
this should not exist in such a base class
Formulka
force-pushed
the
RemoveImplicitISODateTimeField
branch
from
d322cb9 to
0e4b583
Compare
Pull Request Test Coverage Report for Build 4195441420Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.