OpenSearch indexes partitioned to daily partitions #4
Conversation
xdaniel3
commented
Oct 31, 2023
xdaniel3
commented
- allow to match them through pattern matching
xdaniel3
force-pushed
the
tda/feat/index_pattern_matching
branch
2 times, most recently
from
3ff7082 to
a7e9f1c
Compare
Pull Request Test Coverage Report for Build 6796045226
💛 - Coveralls |
xdaniel3
force-pushed
the
tda/feat/index_pattern_matching
branch
7 times, most recently
from
c3caaa9 to
47959df
Compare
xdaniel3
force-pushed
the
tda/feat/index_pattern_matching
branch
from
47959df to
350dab1
Compare
- allow to match them through pattern matching
xdaniel3
force-pushed
the
tda/feat/index_pattern_matching
branch
from
350dab1 to
071ed96
Compare
| @@ -3,6 +3,7 @@ | |||
| from django.test.utils import override_settings | |||
|
|
|||
| from .models import CommandLog, CeleryTaskRunLog, CeleryTaskInvocationLog, InputRequestLog, OutputRequestLog | |||
| from .models import PartitionedLog | |||
There was a problem hiding this comment.
why is there another import line instead of an addition to the one above?
There was a problem hiding this comment.
why not use parentheses instead? they are used elsewhere int he project
There was a problem hiding this comment.
Ok, but let's incorporate some linting, it's hard to search in project what conventions should be used.
| template = document_class.get_template() | ||
| template.save() | ||
| else: | ||
| document_class.init() |
There was a problem hiding this comment.
Wouldn't it be better to override the init method of the PartitionedLog and save the template there? You could remove this whole if/else change in both places and it would comform to the pattern of the other Documents.
There was a problem hiding this comment.
init is particularly for creating index, while I create here just a template, so it might be confusing imho. This implementation is directly from documentation of elasticsearch-dsl for time-based indexes.
But it could be in some function, that's for sure.
