Merge pull request #59 from skiptomyliu/2022-08-15

Fix crash when selecting artist link from now playing
skiptomyliu · Aug 28, 2022 · ece3fb9 · ece3fb9
2 parents 12df190 + d0aedf9
commit ece3fb9
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/App/Milkshake.dmg b/App/Milkshake.dmg
diff --git a/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/UserInterfaceState.xcuserstate b/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist b/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
@@ -76,8 +76,8 @@
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "52"
             endingLineNumber = "52"
-            landmarkName = "actionSelectedCell(sender:)"
-            landmarkType = "7">
+            landmarkName = "unknown"
+            landmarkType = "0">
          </BreakpointContent>
       </BreakpointProxy>
       <BreakpointProxy

diff --git a/Milkshake/Info.plist b/Milkshake/Info.plist
@@ -19,9 +19,9 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.3.0</string>
+	<string>1.3.1</string>
 	<key>CFBundleVersion</key>
-	<string>41</string>
+	<string>42</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.music</string>
 	<key>LSMinimumSystemVersion</key>

diff --git a/Milkshake/MainViewController.swift b/Milkshake/MainViewController.swift
@@ -274,7 +274,7 @@ class MainViewController: NSViewController {
                         let cell = rvc.searchTableView.view(atColumn: 0, row: i, makeIfNecessary: false) as! SearchTableCellView
                         if (
                             // skip shuffle banner
-                            !cell.item.isShuffle! && (
+                            !(cell.item.isShuffle ?? false) && (
                             // check song
                             cell.item.pandoraId == music.curPlayingItem.pandoraId ||
                             // check station
@@ -537,7 +537,7 @@ extension MainViewController: CellSelectedProtocol {
             }
         }
         else if type == MusicType.SHUFFLESTATION {
-            if item.isShuffle! {
+            if item.isShuffle ?? false {
                 if !self.appDelegate.radio.isShuffle {
                     self.appDelegate.api.shuffleStation(stationsIds: [], callbackHandler: callbackShuffle)
                 }

diff --git a/README.md b/README.md
@@ -7,7 +7,7 @@ Milkshake is a Mac OS X [Pandora](https://www.pandora.com) client.
 
 If you don't have a Pandora account, you can [sign up here](https://www.pandora.com/account/register)
 
-# Download v1.3.0
+# Download v1.3.1
 [💾 DMG Installer](https://github.com/skiptomyliu/milkshake/raw/master/App/Milkshake.dmg)