Skip to content

Conversation

@atalakey
Copy link

No description provided.

uninstall.sh Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bother with GOROOT or VERSION, but instead do DIR=$GOPATH/src/github.com/skirkpatrick. That is where it actually gets installed assuming GOPATH is set correctly.

@skirkpatrick
Copy link
Owner

Github won't let me automatically merge this, so I might not get around to it until next week (I'm kind of busy).

I left a comment in the diff that should be fixed. Also, I'm going to cherry-pick out the commit moving the executable. Since the executable gets but in $GOPATH/bin it will automatically be recognized by PATH, assuming Go was installed correctly (ie, with GetGo :P).

@atalakey
Copy link
Author

Hey man i fixed the merge problem and i made the changes to uninstall.sh. Take a look and let me know if i need to change any thing else

@skirkpatrick
Copy link
Owner

Looks pretty good. The merge conflicts aren't anything you'll be able to fix. It's stuff in the install script because of some updates to it that I'd done. I'll be able to fix them from the command line, so don't worry about it.

I have no problem merging this as-is, but if you could put in a check to remove $GOPATH/src/github.com/skirkpatrick and/or $GOPATH/src/github.com if they are empty then that would be awesome. I know you don't need anymore contributions, so if you don't feel like doing that part then I'll take a crack at it. Just let me know.

@atalakey
Copy link
Author

I made the changes, take a look and let me know if i can do anything else.

@skirkpatrick
Copy link
Owner

Thanks! Looks good! Like I said, I'll get around to merging this next week. Too busy with numerical/p8/packing right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants