-
Notifications
You must be signed in to change notification settings - Fork 0
Added an uninstallation script #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
uninstall.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bother with GOROOT or VERSION, but instead do DIR=$GOPATH/src/github.com/skirkpatrick. That is where it actually gets installed assuming GOPATH is set correctly.
|
Github won't let me automatically merge this, so I might not get around to it until next week (I'm kind of busy). I left a comment in the diff that should be fixed. Also, I'm going to cherry-pick out the commit moving the executable. Since the executable gets but in |
|
Hey man i fixed the merge problem and i made the changes to uninstall.sh. Take a look and let me know if i need to change any thing else |
|
Looks pretty good. The merge conflicts aren't anything you'll be able to fix. It's stuff in the install script because of some updates to it that I'd done. I'll be able to fix them from the command line, so don't worry about it. I have no problem merging this as-is, but if you could put in a check to remove |
|
I made the changes, take a look and let me know if i can do anything else. |
|
Thanks! Looks good! Like I said, I'll get around to merging this next week. Too busy with numerical/p8/packing right now! |
No description provided.