Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swiping between group pages can be a bit laggy with lots of tracks #63

Closed
skjiisa opened this issue Jul 12, 2021 · 3 comments
Closed

Swiping between group pages can be a bit laggy with lots of tracks #63

skjiisa opened this issue Jul 12, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@skjiisa
Copy link
Owner

skjiisa commented Jul 12, 2021

It feels a bit laggy swiping between groups when the "All Tracks" group is enabled and there are a large number of tracks (more than 10 total tracks, with over 30 displayed total among all of the groups).

Using a LazyHStack in PageView instead of the regular HStack didn't seem to make a difference.
@skjiisa skjiisa added the bug Something isn't working label Jul 12, 2021
@skjiisa
Copy link
Owner Author

skjiisa commented Jul 12, 2021

Could maybe be alleviated with #53.

@skjiisa skjiisa added this to the v1.3 milestone Sep 30, 2021
@skjiisa
Copy link
Owner Author

skjiisa commented Oct 1, 2021

#53 does help, but there's still a lag spike when you start dragging to a new screen.

@skjiisa skjiisa removed this from the v1.3 milestone Nov 4, 2021
@skjiisa
Copy link
Owner Author

skjiisa commented Nov 4, 2021

Closed in f7711aa

@skjiisa skjiisa closed this as completed Nov 4, 2021
skjiisa referenced this issue Nov 4, 2021
@skjiisa
Fix laggy page swiping
f7711aa 
Finally! And It ended up being so easy once I knew what to do.
You'll notice when rotating the device that it's still laggy to update, however, which I think is an indication that my views aren't very efficient and are expensive to reload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skjiisa