Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PageView with PageTabViewStyle #53

Open
skjiisa opened this issue Jul 1, 2021 · 2 comments
Open

Replace PageView with PageTabViewStyle #53

skjiisa opened this issue Jul 1, 2021 · 2 comments
Labels
refactor Code that should be refactored
Milestone
UI Redesign

Comments

@skjiisa
Copy link
Owner

skjiisa commented Jul 1, 2021

iOS 14.5 seems to have fixed the issues with PageTabViewStyle, so PageView can be replaced with that. I don't know if there's any specific benefit to it, but it could be done. Low priority issue.
@skjiisa skjiisa mentioned this issue Jul 12, 2021
Closed
@skjiisa skjiisa added the refactor Code that should be refactored label Jul 12, 2021
@skjiisa
Copy link
Owner Author

skjiisa commented Nov 4, 2021

This would make #75 more difficult. We likely don't need this anymore as laggy swiping has been resolved in f7711aa and keeping our own paging system gives more flexibility for stuff like #75.

@skjiisa skjiisa added this to the v1.3 milestone Nov 4, 2021
@skjiisa skjiisa mentioned this issue Nov 19, 2021
Draft
@skjiisa
Copy link
Owner Author

skjiisa commented Nov 19, 2021

Current plan is to replace with implementation from vertical-scroll (#79).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code that should be refactored
Projects
None yet
Milestone
UI Redesign
Development

No branches or pull requests
1 participant
@skjiisa