-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Redesign #79
Draft
skjiisa
wants to merge
15
commits into
main
Choose a base branch
from
vertical-scroll
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
UI Redesign #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Tickmate/Tickmate/Views/ContentView.swift
Remove print statements Fix timing curve values for push animation
Update Introspect to 0.1.3 for fixed ScrollView bug
Stop lazily loading as it was actually less performant than rendering everything, even with a large number of tracks and groups
This was referenced Nov 19, 2021
Open
Tapping tracks currently does nothing
Things that still need to be done
|
The old ticks view is being used for the widget and works just fine, so I feel like it can just be left as-is until we actually want to update the widget. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI redesign using a custom paging view that maintains vertical scroll position while having some neat new designs.
Should address #53, #75, and #76.
Currently not ready to merge.