[WIP] Implement aws.IsVirtualHostableS3Bucket function. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Sep 15, 2022
skmcgrail
pushed a commit
that referenced
this pull request
Sep 30, 2022
rcoh
added a commit
that referenced
this pull request
Nov 18, 2022
* Rules Engine Initial Port * Incorporate Latest Rules Engine Commits eb43dc73...c92510ca * Fix several cases where serializers were missing and add round-trip tests (#1) * Change namespace from reterminus to language * Move resources to correct classpath locations * Mark unstable, make classes final that can be * Add UseGlobalEndpoint builtins for STS/S3 * Make UseGlobalEndpoints default to false. * Prune synthesizer components * Update the PartitionFn to fallback to the AWS partition * Add more tests of hostLabel standard library function * Add disable MRAP builtin * constrain substring to the set of ascii characters * fix doc comment * Integrate Smithy Rules Engine Traits (#8) * smithy-rules-engine trait fixes * Integrate of smithy-rules-engine traits * Fixed additional trait issues (#9) * Fix checkstyle * Windows fixes * Removed endpoints.json (#10) * add partition names to output (#11) * Rename language to syntax * Add aws-iso global regions. * Fix tests to pass latest partitions.json (#13) * Add S3Control builtin + EndpointRuleset toBuilder (#14) * Fix addRules -> rules usage * MandatorySourceLocation cleanups * Lots of refactors + extract function registry * refactor booleanequals and string equals * Fixups * More cleanups: good by eval trait * Delete FnVisitor & address CR feedback * Add more comments * Implement aws.IsVirtualHostableS3Bucket function. (#16) * Add condition methods to GetAttr * Add functions for isVirtualHostableS3Bucket to Expr * Fix Parameters toBuilder * Remove the EndpointRulesetCustomization interface (#17) * Add additional checks for invalid labels + ip addresses (#18) * Add a test case for empty host label * First pass at cleanup * Fix substring * Replace newlines in invalidTestCase tests (possible windows fix) * Compact whitespace in IntegrationTests#invalidTestCases * Replace test paths in IntegrationTest with OS independent seperators Co-authored-by: Russell Cohen <russell.r.cohen@gmail.com> Co-authored-by: Alex Woods <alexwoo@amazon.com> Co-authored-by: Russell Cohen <rcoh@amazon.com> Co-authored-by: Alex Woods <alextwoods@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is pending review/acceptance of specification changes.
Description of changes:
Implement the new aws.IsVirtualHostableS3Bucket function.
Rules:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.