-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup_for_epub3 prevents reproducible builds #97
Comments
After a bit more thinking, possibly what you did is not as good. Now, last modified will not update if you load existing epub, modify it and save back. Right? Seems like, we actually need an option to say whether to update last modified date or not. |
@skoji what do you think? |
Yes, that’s right. Original behavior is intended to prevent that case. But the original behavior also made |
OK I'm going to change on parsed EPUB: Update lastmodified on save even if parsed lastmodified exists, unless client explicitly sets lastmodified. |
This is a continuation of skoji#97.
This is a continuation of skoji#97.
Currently, it is impossible to create two byte-to-byte identical EPUB files via gepub because it unconditionally sets modified time to current time when user calls
generate_epub_stream
orgenerate_epub
.Please, add an option to disable this behavior, so that gepub user can explicitly set modified date to a fixed timestamp. Alternative way: only update modified date in
cleanup_for_epub3
if it wasn't set explicitly.More info about reproducible builds concept is available on https://reproducible-builds.org/
The text was updated successfully, but these errors were encountered: