Restore compatibility with rubyzip < 2.1.0 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
force-pushed
the
older-rubyzip
branch
from
5aae82d to
cc6e031
Compare
skoji
requested changes
Feb 12, 2020
.github/workflows/test.yml
Outdated
| @@ -6,6 +6,7 @@ jobs: | |||
| matrix: | |||
| ruby: [2.4, 2.5, 2.6, 2.7, jruby] | |||
| platform: [ubuntu-latest, macos-latest, windows-latest] | |||
| rubyzip: [1.1.2, ''] | |||
There was a problem hiding this comment.
Usually, a test should be written for a fixed bug, so this is good. But I think it is not necessary for this case. I don't think gepub will use a new rubyzip API in the near future.
I propose to remove rubyzip variation test from the test matrix.
There was a problem hiding this comment.
I don't think gepub will use a new rubyzip API in the near future.
Well, it happened unintentionally.
I propose to remove rubyzip variation test from the test matrix.
Okay, updated PR.
Turns out, Zip::DOSTime.from_time only appeared in 2.1.0: rubyzip/rubyzip@2bdd37d
slonopotamus
force-pushed
the
older-rubyzip
branch
from
cc6e031 to
f87c1bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I broke this in #106
I'm not sure you want to test that much combos on GH-Actions, feel free to ask for adjustments.