Skip to content

update nokogiri requirement to < 2.0 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2021
Merged

update nokogiri requirement to < 2.0 #131

merged 1 commit into from
Oct 9, 2021

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 28, 2021

they've been following semver, so the requirement can be more lenient

@ccutrer
update nokogiri requirement to < 2.0
b8a4449 
they've been following semver, so the requirement can be more lenient
skoji
skoji previously approved these changes Oct 5, 2021
View reviewed changes
@skoji skoji dismissed their stale review October 5, 2021 02:29

I've accidentaly pushed approve button.

@ccutrer
Copy link
Contributor Author

ccutrer commented Oct 5, 2021

for reference: https://nokogiri.org/#semantic-versioning-policy

skoji
skoji approved these changes Oct 9, 2021
View reviewed changes
Copy link
Owner

@skoji skoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is logical to trust semver, but almost every human makes mistakes.
But Nokogiri's API is very stable so far and I think I can trust Nokogiri's developer.

@skoji skoji merged commit c1448ef into skoji:main Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoji skoji skoji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccutrer @skoji