You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
The latest release (1.4.0) introduced a new functionality "added type checks to localizers". And it's definitely a breaking change, because it breaks code like
consttotal=6;i18n`Up to ${total} integrations`
So at least it should be a major version change. But in my opinion the project shouldn't have this functionality at all, because what is wrong with this code? It's pretty straightforward, you can always use .toString() implicitly, and after all it's a JavaScript, a language where you don't care about types and can spit on OOP 😄
The text was updated successfully, but these errors were encountered:
sorry, this was not intended. It should only check if you use type formatters for date and number formats.
It was intended to give a better debugging experience if you accidentally format a null/undefined or some other object as date or number like i18n`Current Date: ${null}:t(D)`
arthot
changed the title
Type checks is a breaking change
Type checking is a breaking change
Jul 21, 2018
sorry for the huge delay, I have so much work on my desk right now. happy to receive a pull request on this topic but also willing to work on this as soon as I find some free time.
Hi!
The latest release (1.4.0) introduced a new functionality "added type checks to localizers". And it's definitely a breaking change, because it breaks code like
So at least it should be a major version change. But in my opinion the project shouldn't have this functionality at all, because what is wrong with this code? It's pretty straightforward, you can always use
.toString()
implicitly, and after all it's a JavaScript, a language where you don't care about types and can spit on OOP 😄The text was updated successfully, but these errors were encountered: