Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node version in DockerFile (12.4.0) is has broken TLS handling #306

Open
ckwalsh opened this issue Feb 23, 2022 · 1 comment
Open

Node version in DockerFile (12.4.0) is has broken TLS handling #306

ckwalsh opened this issue Feb 23, 2022 · 1 comment

Comments

@ckwalsh
Copy link
Contributor

ckwalsh commented Feb 23, 2022

I encountered an issue when configuring skooner to use an auth server with a self-signed certificate, produced by step-ca. After going down the rabbit hole, I found nodejs/node#11771 , which matches what I observed.

The bug was resolved around Node 12.14, I'm not sure exactly which version. When I update the Dockerfile to node:12.22.10-alpine and rebuild locally, I no longer encounter the error, and Skooner works properly.

Please update the node version in the Dockerfile so I can run off the stable tag.
ckwalsh added a commit to ckwalsh/skooner that referenced this issue Feb 23, 2022
@ckwalsh
Upgrade node in Dockerfile from 12.4.0 to 12.22.10
2867663 
I personally ran issue an issue with a bug in Node TLS handling
(nodejs/node#11771). This bug was fixed in
approximately 12.14.0, and does not show up when I test with v12.22.10,
the latest v12 release at the time of this commit.

(Issue306)[skooner-k8s#306]

Test Plan: Built image locally, deployed to microk8s cluster. No longer
experiencing issue with parsing TLS certs.

Signed-off-by: Cullen Walsh <ckwalsh@cullenwalsh.com>
@ckwalsh ckwalsh mentioned this issue Feb 23, 2022
Merged
ckwalsh added a commit to ckwalsh/skooner that referenced this issue Feb 23, 2022
@ckwalsh
Upgrade node in Dockerfile from 12.4.0 to 12.22.10
6578711 
I personally ran issue an issue with a bug in Node TLS handling
(nodejs/node#11771). This bug was fixed in
approximately 12.14.0, and does not show up when I test with v12.22.10,
the latest v12 release at the time of this commit.

skooner-k8s#306

Test Plan: Built image locally, deployed to microk8s cluster. No longer
experiencing issue with parsing TLS certs.

Signed-off-by: Cullen Walsh <ckwalsh@cullenwalsh.com>
@calnighters
Copy link

Hi, I would be interested in how you got your self signed cert installed into the container to work. Do you have an example of the docker image you built?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckwalsh @calnighters