ENH add private arg to push #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Narsil @osanseviero do we not want to support private repos on the inference side? I wanted to have all repos created by the CI to be private, but we can't test the inference engine if we make them private. |
|
I'd say we can merge (if the CI is green) and make the inference test repo private once/if we support that in the backend side. cc @skops-dev/maintainers |
BenjaminBossan
approved these changes
Sep 6, 2022
| dst.rmdir() | ||
|
|
||
| # remove the folder only if it's empty and it exists | ||
| if dst.exists(): |
There was a problem hiding this comment.
I'm a bit astonished that the missing check did not cause trouble so far.
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
|
adding some more docs ... |
|
Now done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112 and #114