Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH permutation importance #142
ENH permutation importance #142
Changes from 1 commit
18ef31b
2ff7a5c
5b8d4c9
ae99b89
e80359d
4ef3549
133cc2e
1c448bc
95ad03b
2bc714f
b457fb9
7228e83
9471c76
48c656d
a514060
ac699c5
76e5b0e
baccd1b
d3d0c1c
2489693
a7ba718
1735a01
8dd9692
1462ac2
510d41b
583c16d
2828ae2
97ebde9
ce75f12
dd6e7aa
fcc16dd
7fbaf89
a3435b8
abba95b
d0adddf
003544f
1da4747
280c602
1521444
61d1784
35b5196
5e5d6b3
2bf6c81
0465163
8bf590e
64996fb
298f6fb
e03d30f
c9b8813
a71cdac
9e63a42
ec82e47
e33e254
da185f5
d66be43
b183d9c
ff9c7bf
3a93880
bdeabc4
e999a6f
c9219d5
bb864a6
9113aad
5e80732
322ed4d
e5afe26
95189d8
55b968d
6e3fd2b
9d98003
17e0253
2b4df99
cf18588
7a02cd4
602b8d2
c23f63f
5407351
e046f88
a16d83f
fce9b14
1281274
01a5d78
77f9f8c
7c70656
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is assumed that pandas is installed. However, pandas is not a strict dependency for skops. I think we specifically didn't want to add pandas because it is a "fat" dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I thought of it as well, I will try to plot without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in terms of API, it would make sense to accept importances in a certain way, like accepting both a dict and a pandas dataframe, and then add it to the modelcard.
It doesn't have to be permutation importance.