Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI add codecov token to uploader #253

Merged
merged 1 commit into from
Dec 14, 2022
Merged

CI add codecov token to uploader #253

merged 1 commit into from
Dec 14, 2022

Conversation

adrinjalali
Copy link
Member

Adding codecov token to the CI hoping that it'd help with the codecov upload issues.

@adrinjalali
Copy link
Member Author

@BenjaminBossan this might make you happier 😁

BenjaminBossan
BenjaminBossan approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fingers crossed that this solves the issue, but from my understanding it shouldn't be necessary in the first place.

@BenjaminBossan BenjaminBossan merged commit adde14d into skops-dev:main Dec 14, 2022
@adrinjalali adrinjalali deleted the codecov-token branch December 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @BenjaminBossan