Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: increase client name prominence #154

Conversation

rosenbach
Copy link
Contributor

@rosenbach rosenbach commented Mar 24, 2023

This PR makes the "Client Name" field more prominent than the "Client ID" throughout the application.
It refactors the UI in order to improve the UX in the case of using non-human-readable Client IDs and now encourages separating the technical detail "Client ID" of the "Client Name".

Changes include:

  • update (ordering of) breadcrumb
  • Client Edit Page now shows the Name prominently, not the ID.
  • make IDs more visually clear as a technical detail by wrapping them into a <code> tag
  • Re-ordering of fields, putting Client Name in the first place in the reading direction

Screenshot of some of the changes:
image

Before:
image


Re-ordering of fields, putting Client Name in the first place in the reading direction:

Here to the left
image
Here to the top
image

@skoruba
Copy link
Owner

skoruba commented May 17, 2023

Thank you, this looks nice, I am sorry for delay.

@skoruba skoruba changed the base branch from main to feature/2.1.0 February 7, 2024 12:12
@skoruba skoruba merged commit 6f88f3d into skoruba:feature/2.1.0 Feb 7, 2024
1 check was pending
@skoruba skoruba mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants