Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for using email in addition to username #152

Merged
merged 15 commits into from
Feb 25, 2019

Conversation

xmichaelx
Copy link
Contributor

If user will enter instead of username his email this will check if such email exist and then proceed with authentication.

In order to prevent from guessing username from email whatever user enters will be always returned back to him (thus usage of additional local variable userName).

We can think about adding info that email can be also supplied into localization.

This provides functionality mentioned in #139

@skoruba skoruba self-assigned this Jan 26, 2019
@xmichaelx
Copy link
Contributor Author

Added option for configuring desired behavior for login resolution:

  • use username
  • user email
  • use username or email (if input is a valid email)

In configuration there is additional entry:

"LoginConfiguration": {
  "ResolutionPolicy": "Username"
}

@xmichaelx
Copy link
Contributor Author

Updated for case where someone has usernames that are valid emails.

Copy link
Owner

@skoruba skoruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good 👍

@skoruba skoruba merged commit 8c273f6 into dev Feb 25, 2019
@skoruba skoruba deleted the allow-for-using-email-in-addition-to-regular-username branch February 25, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants