Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker support with .NET Core 3.0 #395

Merged
merged 12 commits into from
Nov 12, 2019

Conversation

bravecobra
Copy link
Contributor

@bravecobra bravecobra commented Nov 10, 2019

I've made this PR based on #367 by @ChrisSzabo. The amount of work to get it all working properly seemed to be more extensive given the branch was getting rather old. I merged in the latest dev branch, containing the latest .NET Core 3.0 support (#390 ) and the Audit logging (#391 )

So what's changed?

  • Fixed the IdentityServerBaseUrl for Swagger API as mentioned in docker support #367
  • Fixed Swagger redirect URI misconfiguration
  • Fixed the outstanding merge conflicts of docker support #367
  • Merged the latest dev branch
  • Changed the environment variable to use double underscore. It worked in VS2017 with colons, but VS2019 seems to require it in order to debug properly. docs and SO
  • Added a docker-compose.vs.debug.yml and docker-compose.vs.debug.yml to enable debugging with a seeded environment.

We'll need to update the docs, but I suggest getting this in first.

So now we have the following possibility to get a running seeded and debug-able (in VS) environment:

docker-compose build
docker-compose up -d

This PR closes #121

@bravecobra bravecobra mentioned this pull request Nov 10, 2019
@skoruba
Copy link
Owner

skoruba commented Nov 11, 2019

Amazing work @bravecobra - thanks a lot 😊 I will test it ASAP 👍

@skoruba skoruba requested review from skoruba and xmichaelx November 11, 2019 08:36
@bravecobra
Copy link
Contributor Author

Don't forget that this still assumes you have the proper migrations generated in place. We can fix that later in the build pipeline I've prepared with github actions. One step at the time...

@xmichaelx
Copy link
Contributor

xmichaelx commented Nov 11, 2019

Looks solid - i've checked the changes in file. Later today I'll download, build and test it on Ubuntu but I think that we want to merge it ASAP.

@xmichaelx
Copy link
Contributor

Looks ok, let's merge it @skoruba

@skoruba skoruba merged commit 0ee5f6f into skoruba:dev Nov 12, 2019
@bravecobra bravecobra deleted the feature/docker-support-rherlt-base branch November 12, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants