Add Additional Role Claims Functionality #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, I will check it. 👍 |
|
That's good input, however, we might add UI to that 👍 |
ruzanowski
reviewed
Dec 4, 2020
|
|
||
| var added = await IdentityRepository.AddClaimToRolesAsync(roleIds, roleClaimType, roleClaimValue); | ||
|
|
||
| await AuditEventLogger.LogEventAsync(new RoleClaimDeletedFromRolesEvent(roleClaimType, roleIds)); |
There was a problem hiding this comment.
Wrong event. Should be: RoleClaimAddedToRolesEvent
ruzanowski
reviewed
Dec 4, 2020
| Task<TRoleClaimsDto> GetRoleClaimAsync(string roleId, int claimId); | ||
|
|
||
| Task<int> DeleteRoleClaimsAsync(TRoleClaimsDto role); | ||
|
|
||
| Task<IdentityResult> DeleteRoleAsync(TRoleDto role); | ||
|
|
||
| Task<int> DeleteClaimForRolesAsync(List<string> roleIds, string roleClaimType); |
ruzanowski
suggested changes
Dec 4, 2020
| { | ||
| var rolesQ = from r in DbContext.Set<TRole>() | ||
| join rc in DbContext.Set<TRoleClaim>() on r.Id equals rc.RoleId | ||
| where rc.ClaimType.Equals(roleClaimType) && roleIds.Contains(r.Id.ToString()) |
There was a problem hiding this comment.
roleIds.Contains(r.Id.ToString()) in EFCore3.1 is not translated.
try: roleIds.Contains(((string)(object)r.Id))
More info: dotnet/efcore#20604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following functionality to Admin API
I believe this is a good introduction to having more functionality around Role Claims.