Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Memory Corruption #302

Open
shufps opened this issue Aug 17, 2024 · 0 comments · May be fixed by #471
Open

Possible Memory Corruption #302

shufps opened this issue Aug 17, 2024 · 0 comments · May be fixed by #471
Labels
bug Something isn't working

Comments

@shufps
Copy link
Contributor

shufps commented Aug 17, 2024 •
edited
Loading

The hex2bin len parameter takes the destination length that is HASH_SIZE and not the source length.

ESP-Miner/components/stratum/stratum_api.c

Line 238 in 80e72cc

hex2bin(cJSON_GetArrayItem(merkle_branch, i)->valuestring, new_work->merkle_branches + HASH_SIZE * i, HASH_SIZE * 2);

The last hex string converted overwrites 32 bytes of memory not allocated
@WantClue WantClue added the bug Something isn't working label Aug 17, 2024
mutatrum added a commit to mutatrum/ESP-Miner that referenced this issue Nov 11, 2024
@mutatrum
Set proper size in hex2bin call
bbc5114 
Fixes skot#302
@mutatrum mutatrum linked a pull request Nov 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set proper size in hex2bin call mutatrum/ESP-Miner
2 participants
@shufps @WantClue