Set proper size in hex2bin call #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdb3
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Good catch.
Reviewed the change and ran a quick local test feeding hex2bin a 32-byte C string containing a hash, with bin_len set to HASH_SIZE. Printed each byte written to bin and saw the correct hash. Did not build deploy esp-miner to a bitaxe with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
It actually doesn't corrupt memory, as hex2bin stops on null termination of the string provided by cJSON. But it's still better to have the correct len value passed to hex2bin.