fix Best Difficulty can not be > 4.29G #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would make more sense for this to be a uint64_t as that's what is stored in NVS, we also don't need the precision for display. Good catch though! |
|
@benjamin-wilson, thanks for your comment. I agree with you and PR is updated. |
aaron3481
pushed a commit
to aaron3481/ESP-Miner
that referenced
this pull request
Jun 11, 2024
* fix best_nonce_diff, uint32_t is too small * best_nonce_diff as uint64_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best_nonce_diff used to be defined as uint32_t (max value 4294967295). IMHO it should (at least) be defined as double otherwise Bitaxe UI might show a far too low 'Best Difficulty' value (can not be > 4.29G (uint32_t max value)).
I noticed this as public-pool is showing "Your Best Difficulty: 15.46G" but Bitaxe UI claims just "Best Difficulty: 4.29G"