Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fan speed web update #141 #222

Merged
merged 14 commits into from
Jun 20, 2024
Merged

Fixed fan speed web update #141 #222

merged 14 commits into from
Jun 20, 2024

Conversation

tommywatson
Copy link
Contributor

These changes fix fan rpm/percent requested and update both on the web

Fixed fan speed web update skot#141
2797723 
These changes fix fan rpm/percent requested and update both on the web
Georges760
Georges760 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@Georges760 Georges760 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skot skot self-assigned this Jun 20, 2024
@skot
Copy link
Owner

skot commented Jun 20, 2024

this isn't working on my 401. On first loading up AxeOS I see the following; (my fan is definitely spinning)
image

If I turn off auto fan speed it shows this;
image

skot
skot requested changes Jun 20, 2024
View reviewed changes
Copy link
Owner

@skot skot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flashed this PR to my 401 and loaded up AxeOS. everything looks good except the fan speed percentage gauge is showing 0%

Georges760 and others added 12 commits June 20, 2024 14:01
@Georges760
fix readme
8ce9ba1
@Georges760
refactor self_test to be modular for new hardware
44e3fb3
@Georges760 @skot
Supra 402 (skot#221)
2a5d27e 
* port TCH Supra 402 branch

* refactor TMP1075 (unused?) driver using i2c_master module

* pulled in @BitMaker-hub stratum_task.c DNS changes from PR skot#185

* removing serial debug

---------

Co-authored-by: Skot <skot@bitnet.cx>
@skot
adjust share accpeted/rejected functions to take higher level GLOBAL_…
2a97b8c 
…STATE to fix share accounting.
@tommywatson
Code clean resulting from looking into skot#218 (skot#220)
982e45e 
* Code clean resulting from looking into skot#218

* Fixed asic count

Set canary value for invalid device's asic_count

---------

Co-authored-by: tommy <tommy@tommywatson.com>
@Georges760
fix another pointer error
0c9068d
@dadofsambonzuki
Changes efficiency metric display in AxeOS (skot#231)
8f685c7 
Fixes skot#230
@Georges760 @skot
try to explain nonce space duration from paramters (skot#228)
27a1ebe 
* try to explain nonce space duration from paramters

* Fix Nonce Space duration for BM1397 (no version-rolling)

* fixed issue with version mask on 1397. added easy serial debugging on 1397

* cleanup jobID debugs

---------

Co-authored-by: Skot <skot@bitnet.cx>
@yanir99
Update bm1397.c to increase the max frequency to 650Mhz (skot#209)
f55c6d7 
* Update bm1397.c to increase the max frequency to 650Mhz

The original version was setting everything above 500Mhz to 500Mhz, the update increases the limit to 650Mhz.
No changes to the web interface - drop-down still shows up to 575Mhz

* Update edit.component.ts to include higher freqeuncy for BM1397

* Updated BM1397 frequencies to above 500Mhz

* Update bm1397.c

* Update bm1397.c

* UN-Update readme.md

* Update bm1397.c

* Update bm1397.c

* Update bm1397.c
@tdb3
fix: add recovery page (skot#232)
a93c350 
Adds a recovery web interface to enable users
to recover from a failed www.bin update.
Partial fix for Issue skot#213.
@tdb3
refactor: unify merge_bin scripts (skot#189)
269939b 
Combines the functionality of merge_bin_update.sh
and merge_bin_with_config.sh into merge_bin.sh.
Also adds more verbose usage printing.
@tdb3
fix: check www.bin size before updating (skot#216)
081714d 
Adds a basic sanity check for www.bin uploading.
Returns 400 if upload is attempted on a file larger
than the available partition space.
@skot
Copy link
Owner

skot commented Jun 20, 2024

nice, this seems to be working on 204 and 401

@skot
Copy link
Owner

skot commented Jun 20, 2024

we need to hide the Voltage Regulator Temperature on everything but 207, 30x, and 402, but maybe that's another issue.
image

@tommywatson
Copy link
Contributor Author

we need to hide the Voltage Regulator Temperature on everything but 207, 30x, and 402, but maybe that's another issue. image

I think that should be separate, I don't know what the max rpm is on the fans, so with some testing we should hone the RPM in to closer match the "Fan %" reading.

skot
skot approved these changes Jun 20, 2024
View reviewed changes
Copy link
Owner

@skot skot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skot skot merged commit c011895 into skot:master Jun 20, 2024
1 check passed
@skot
Copy link
Owner

skot commented Jun 20, 2024

I added a separate issue for the vreg temp; #237

Yeah, I was noticing that the fan RPM doesn't match the percentage. My fan from the screenshot is 5k max RPM, so 4503RPM should be 90%

I think the issue is that 90% refers to the PWM duty cycle, which doesn't really map to fan speed percent directly. Pretty sure the EMC2101 fan controller we use has some features to sort this out.

@tommywatson
Copy link
Contributor Author

It's the 20000 on this line, it sounds like it should be set to something just above 5k?

ESP-Miner/main/http_server/axe-os/src/app/components/home/home.component.html

Line 148 in a3f3818

<p-knob [min]="0" [max]="20000" [readonly]="true" [(ngModel)]="info.fanrpm"

@skot
Copy link
Owner

skot commented Jun 20, 2024

I think that will make the UI line up a little bit better. But it doesn't change the fact that 4503 isn't 58% of 5000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Georges760 Georges760 Georges760 approved these changes

@skot skot skot approved these changes

Assignees

@skot skot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tommywatson @skot @Georges760 @dadofsambonzuki @yanir99 @tdb3